Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(adapter-nextjs): add user has signed in check before initiating sign-in and sign-up #13839

Open
wants to merge 1 commit into
base: hui/feat/adapter-nextjs/3-auth-api-handlers-impl
Choose a base branch
from
Open

feat(adapter-nextjs): add user has signed in check before initiating sign-in and sign-up #13839

wants to merge 1 commit into from

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Sep 23, 2024

Description of changes

  • Add a check to determine whether an end user has already signed in before initiating a sign-in or sign-up flow

Issue #, if available

Description of how you validated changes

  • Unit tests
  • Manual testing with next.js sample apps created with the app router and the pages router.

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/3-auth-api-handlers-impl branch from 621d0cb to 284acbf Compare October 1, 2024 23:02
@HuiSF HuiSF requested a review from a team as a code owner October 1, 2024 23:02
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/4-check-signed-in-user branch from 583f9f0 to df708b8 Compare October 1, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukhan-amazon ukhan-amazon Awaiting requested review from ukhan-amazon

@haverchuck haverchuck Awaiting requested review from haverchuck haverchuck is a code owner

@cshfang cshfang Awaiting requested review from cshfang cshfang is a code owner

@jimblanc jimblanc Awaiting requested review from jimblanc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HuiSF